[Cooker] Re: r188312 - cooker/pinentry/current/SPECS

[blino]

Anssi Hannula <anssi@mandriva.org> writes:

> blino wrote:
>> Author: blino
>> Date: Mon Mar 17 16:57:30 2008
>> New Revision: 188312
>> 
>> Modified:
>>    cooker/pinentry/current/SPECS/pinentry.spec
>> 
>> Log:
>> do not remove alternatives in postun if the package is not removed
>> 
> [...]
>
>>  %postun gtk
>> -update-alternatives --remove pinentry /usr/bin/pinentry-gtk-2
>> +if [ "$1" = "0" ]; then
>> +   update-alternatives --remove pinentry /usr/bin/pinentry-gtk-2
>> +fi
>
> Better use 'if [ ! -e "%{_bindir}/pinentry-gtk-2" ]; then', in case in
> the future the binary name changes or the package gets obsoleted or
> something else.

Right, but we should have a rpm-helper macro to handle that, instead
of doing this work manually in all spec files.
Your remark is valid for a lot of packages.

-- 
Olivier Blin (blino) - Mandriva